feat(Keycard): Adding a keycard info drawer for Android to guide the keycard interactions#19549
Merged
alexjba merged 8 commits intofix/keycard-nfc-3from Jan 14, 2026
Merged
feat(Keycard): Adding a keycard info drawer for Android to guide the keycard interactions#19549alexjba merged 8 commits intofix/keycard-nfc-3from
alexjba merged 8 commits intofix/keycard-nfc-3from
Conversation
This was referenced Dec 10, 2025
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#1 🔹 ~19 min 🔹 23b6c55 🔹 📦 tests/ui package |
Member
Member
Member
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
86711e0 to
e71a2fa
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
23b6c55 to
7515f6e
Compare
Member
Member
alexjba
requested review from
a team,
caybro,
micieslak and
noeliaSD
as code owners
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#2 🔹 ~37 min 🔹 7515f6e 🔹 📦 tests/ui package |
Member
Member
Member
✔️ status-desktop/e2e/prspr19549 🔹 ~17 min 🔹 7515f6e 🔹 📦 tests/e2e package |
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e71a2fa to
adabada
Compare
alexjba
requested review from
friofry and
vkjr
and removed request for
a team
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
7515f6e to
0561ebc
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
adabada to
cd46a72
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
aab486b to
668b750
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
b1b5809 to
1daf137
Compare
alexjba
commented
Dec 22, 2025
Member
Jenkins BuildsClick to see older builds (96)
|
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
668b750 to
e2f0b36
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
1daf137 to
0206c96
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e2f0b36 to
98d9bc1
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
272901d to
48b2d5c
Compare
caybro
reviewed
Jan 5, 2026
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
LGTM in general, just some final questions
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
98d9bc1 to
af922f9
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
48b2d5c to
d087eb9
Compare
caybro
approved these changes
Jan 12, 2026
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
af922f9 to
b8b31ae
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
d087eb9 to
57f91ad
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
b8b31ae to
44d162b
Compare
…keycard interactions Adding a `KeycardChannelDrawer` that's guiding the user whenever the keycard is needed. On IOS the system drawer is used
…ponents - use a single KeycardStateDisplay instance with the necessary states - The state queue, transitions and entire logic moved to KeycardChannelStateManager component
The constants are moved from nim to qml
- Adding states for HW adaptor states - Implement `Dismiss` action
…ing blocked This commit updates parts of the login flows. Adds a new `Scan keycard` button to trigger keycard detection on demand. + Update keycard states in the login flow + Show digits only on soft keyboard for pin input to squash - fix: User needs to be able to dismiss the keycard drawer without getting blocked
…ger keycard detection
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
57f91ad to
449fd86
Compare
Contributor
|
Hey @alexjba, here are some results Samsung Fail Passed
Settings:
Motorola Pass
Settings:
|
Contributor
Author
Great! Thank you very much @glitchminer! Much appreciated! 🍻 IMO the remaining issue is not a blocker and the maintenance cost of all these PRs is quite high. WDYT if we log an issue to be worked on after merging these PRs? |
Contributor
|
@alexjba, that sounds ok, I think it would be fine to get these merged and iterate after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterating
#19545
#19546
#19547
#19548
Adding a
KeycardChannelDrawerthat's guiding the user whenever the keycard is needed.On IOS the system drawer is used.
Screencapture of the functionality
Screen_Recording_20251210_154214_Status.mp4
ScreenRecording_12-10-2025.17-21-13_1.MP4
Screen.Recording.2025-12-10.at.15.11.49.mov
Impact on end user
How to test
desktop:
make run USE_STATUS_KEYCARD_QT=1iOS:
make mobile-run USE_STATUS_KEYCARD_QT=1 DEVELOPMENT_TEAM=...android:
make mobile-run